feat: gitlab pipeline convert#2681
Closed
mappjzc wants to merge 1 commit into
Closed
Conversation
Add gitlab ConvertPipelines. Nddtfjiang <zhicheng.jiang@merico.dev>
warren830
requested changes
Aug 5, 2022
| CommitSha: gitlabPipeline.Sha, | ||
| Branch: gitlabPipeline.Ref, | ||
| Repo: fmt.Sprintf("%d", gitlabPipeline.ProjectId), | ||
| Result: gitlabPipeline.Status, |
Contributor
There was a problem hiding this comment.
after pr #2683 get merged, please modify Result and Status, these two values should be enum
| if gitlabPipeline.GitlabCreatedAt != nil { | ||
| createdAt = *gitlabPipeline.GitlabCreatedAt | ||
| } | ||
| finishedAt := time.Now() |
Contributor
There was a problem hiding this comment.
what if finishedAt should be nil?
| Convert: func(inputRow interface{}) ([]interface{}, error) { | ||
| gitlabPipeline := inputRow.(*gitlabModels.GitlabPipeline) | ||
|
|
||
| createdAt := time.Now() |
Contributor
Author
|
closed because it code move to #2682 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add gitlab ConvertPipelines.
Does this close any open issues?
#2583
Screenshots
Other Information
Any other information that is important to this PR.